Re: Patch for Tulip etherboot driver

[Marty Connor <mdc@thinguin.org>]

On 7/4/2000 11:33 PM Jim McQuillan jam@McQuil.com wrote:

>+  if( rxd[rxd_tail].status & 0x00008000){
>+      rxd[rxd_tail].status = 0x80000000;
>+      rxd_tail++;
>+      if (rxd_tail == NRXD) rxd_tail = 0;
>+      return 0;
>+  }
>+

This looks like an excellent idea to me, Jim.  I think the RTL8139 driver 
had a similar fix applied in the last revision.  Better error checking is 
a good thing.

>-  /* The other Etherboot drivers don't seem to do anything here,
>-     so for now, we will not either */
>-#if	0
>   /* disable interrupts */
>   outl(0x00000000, ioaddr + CSR7);
> 
>@@ -637,7 +645,6 @@
> 
>   /* Clear the missed-packet counter. */
>   (volatile unsigned long)inl(ioaddr + CSR8);
>-#endif

As you can tell from the comment, I always wondered if this routine 
should be turned on.  I think there was some card that didn't boot 
properly if it was, but I am not sure which one.  We could conditionalize 
the code for whichever clone (or clones) it is.

Good job, Jim!  I am sorry I haven't had time to work on the driver, and 
I appreciate your help.

Regards,

Marty


---
   Name: Martin D. Connor
US Mail: Entity Cyber, Inc.; P.O. Box 391827; Cambridge, MA 02139; USA
  Voice: (617) 491-6935, Fax: (617) 491-7046 
  Email: mdc@thinguin.org
    Web: http://www.thinguin.org/


===========================================================================
This Mail was sent to netboot mailing list by:
Marty Connor <mdc@thinguin.org>
To get help about this list, send a mail with 'help' as the only string in
it's body to majordomo@baghira.han.de. If you have problems with this list,
send a mail to netboot-owner@baghira.han.de.